add coercions chapter and split out non hir typeck stuff #2662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
BoxyUwU
force-pushed
the
coercion_docs
branch
from
d99ccca to
c168284
Compare
This was referenced Nov 29, 2025
spastorino
approved these changes
Nov 30, 2025
Member
spastorino
left a comment
spastorino
left a comment
There was a problem hiding this comment.
This chapter looks very good ❤️. Very nice use of examples. Not sure if you want some other feedback but my usual way is, we can merge things that are better than the current state and then improve later.
Co-authored-by: Santiago Pastorino <spastorino@gmail.com>
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chapter feels a bit incomplete without accompanying docs for adjustments and expectations but that can definitely be a future PR ✨ cc #2663
The structure of this chapter is kinda meh, it's mostly just a pile of information in not too much of a thought out reading order